enable @AnalyzeClasses annotation to be used as meta annotation
#1300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathze
force-pushed
the
feature/GH-182-allow-analyzeclass-to-be-used-as-meta-annotation
branch
from
253c79e
to
f28257a
Compare
mathze
commented
May 11, 2024
| @@ -295,11 +300,14 @@ private static class JUnit5ClassAnalysisRequest implements ClassAnalysisRequest | |||
| } | |||
|
|
|||
| private static AnalyzeClasses checkAnnotation(Class<?> testClass) { | |||
| AnalyzeClasses analyzeClasses = testClass.getAnnotation(AnalyzeClasses.class); | |||
| checkArgument(analyzeClasses != null, | |||
| List<AnalyzeClasses> analyzeClasses = new AnnotationFinder<>(AnalyzeClasses.class).findAnnotationsOn(testClass); | |||
There was a problem hiding this comment.
Not sure how to reach this from test.
so far users are forced to repeat `@AnalyzeClasses` annotation an every test class. This cause additional maintenance overhead when common properties (e.g. package structure) changes. To support the DRY approach, `@AnalzyeClasses` annotation can now be used as meta annotation. Resolves: TNG#182 Signed-off-by: Mathze <[email protected]>
mathze
force-pushed
the
feature/GH-182-allow-analyzeclass-to-be-used-as-meta-annotation
branch
from
f28257a
to
4e75e03
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so far users are forced to repeat
@AnalyzeClassesannotation an every test class. This cause additional maintenance overhead when common properties (e.g. package structure) changes. To support the DRY approach,@AnalzyeClassesannotation can now be used as meta annotation.Resolves: #182