Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to check for overriding methods to domain and lang #1200

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

rweisleder
Copy link
Contributor

Resolves: #1198

@rweisleder
Copy link
Contributor Author

I just saw, there is another issue/PR #1040 for the same topic 😅
At the moment, I haven't looked more deeply into whether my implementation is too simple or the other one too verbose.

…lang

I think there is still some problems with generics and bridge methods.

Signed-off-by: Peter Gafert <[email protected]>
@codecholeric
Copy link
Collaborator

Thanks a lot for your contribution and sorry for the slow process 🙈 I see that there is another PR going in the same direction, but from my point of view it a) looks further away from being finished and b) it seems quite abandoned 🤔 So, I think it makes sense to bring this PR here over the finish line.
I think there is still one problem in there with Generics and bridge methods, i.e. when overriding a generic interface, then the bridge method works alright being detected as overriding, but the concrete method containing the fixed type is not detected as overriding. I added a test for this. How do you see this? To me it seems like the concrete overriding method should also be detected as such, right? 🤔

@rweisleder
Copy link
Contributor Author

Generics, how could I have missed them 🤢 You're absolutely right, these are valid cases as well. Maybe I'll find time to complete this soon

sorry for the slow process

I'm part of the slow process as well, no worries

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add predicate to find overridden methods
2 participants