Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix path in output transform pgm #691

Merged
merged 3 commits into from
Jul 18, 2024
Merged

fix path in output transform pgm #691

merged 3 commits into from
Jul 18, 2024

Conversation

sydb
Copy link
Member

@sydb sydb commented Jul 18, 2024

As per #552, @martindholmes and I discovered an error in the Makefile which caused the transformtei program to be created with an incorrect path-correction. Thus if the user was using the default paths no problem would occur, but a custom path (set by the PREFIX variable) would mess things up.

This PR fixes that problem.

See also #551 for an amusing side-effect of the comment that we added to note this problem.

@sydb sydb added target: build Concerning the build process, e.g. the Makefile or build.xml priority: low Not urgent; can be dealt with when someone has free time or is looking for a project. labels Jul 18, 2024
@sydb sydb added this to the Release 7.58.0 milestone Jul 18, 2024
@sydb sydb requested a review from martindholmes July 18, 2024 20:17
@sydb sydb self-assigned this Jul 18, 2024
Copy link
Contributor

@martindholmes martindholmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@sydb sydb merged commit c30704a into dev Jul 18, 2024
4 checks passed
@sydb
Copy link
Member Author

sydb commented Jul 18, 2024

Given that tests pass (not surprising, this change is not tested by the tests, as it is part of the installation process) and @martindholmes approves, I am going to merge & close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: low Not urgent; can be dealt with when someone has free time or is looking for a project. target: build Concerning the build process, e.g. the Makefile or build.xml
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants