Adding templates for val and tag to fix #567 #618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Template added to html/html_core.xsl for tag and val to transform them into spans * Named template added to html/html_core.xsl to create a delimiter span to allow easier customization (i.e. to allow for a CSS only approach to start and end text) * Reflect value of `@scheme` in tag's class
|
I have now merged the TestFile and build information from #508 and did some slight reorganization, so now this PR is ready for review :-) |
|
The Stylesheets Group considers that the |
sydb
approved these changes
Oct 29, 2023
There was a problem hiding this comment.
Turns out the ‘@’ that this PR has rendered by CSS were already being rendered by CSS before this PR. Thus, while I don’t think things are perfect even with this PR, they are certainly better than they were before; furthermore PR seems to work and all tests pass. Thus I think this is ready to be merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@schemein tag's class(See #567 (comment) for additional details)