Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial templating #2

Merged
merged 7 commits into from
Sep 17, 2024
Merged

Initial templating #2

merged 7 commits into from
Sep 17, 2024

Conversation

PaulJWright
Copy link
Collaborator

@PaulJWright PaulJWright commented Sep 17, 2024

No description provided.

Copy link

codecov bot commented Sep 17, 2024

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@PaulJWright PaulJWright self-assigned this Sep 17, 2024
Copy link
Member

@samaloney samaloney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - few comment taken or leave them and a fix for the purewheeels.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.cruft.json Outdated
"author_email": "",
"project_url": "magie.ie",
"license": "BSD 3-Clause",
"minimum_python_version": "3.9",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think just at end of py3.10 support might want to move to 3.10 (https://scientific-python.org/specs/spec-0000/)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's probably a good plan.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have attempted to change everything to 3.10, if you could give a quick sweep that would be appreciated

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have you created an RTD for this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not, I guess this is something you might have to set up, does it need user details etc?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea I requested a group account ages ago but not go so I've created them all under my account should really add @drsophiemurray to them all too.

.ruff.toml Outdated Show resolved Hide resolved
.ruff.toml Outdated Show resolved Hide resolved
@PaulJWright PaulJWright merged commit 8c9c13a into main Sep 17, 2024
13 checks passed
@PaulJWright PaulJWright deleted the feature/initial_templating branch September 17, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants