You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I was wondering why my automatic browser language detection code wasn't working anymore. Tracing the TAPi18n.setLanguage() calls, I finally found out that this package was responsible for setting the language back to English.
I think it's a silly decision to brute-force set the language to the first language available. Why don't you just choose the language that TAPi18n itself reports by TAPi18n.getLanguage() instead? This wouldn't break custom code that ran before. Not everyone wants to use a default language for any user.
At least this behaviour should be clearly documented, especially if it is a breaking change.
In my case, I was setting the language in an Meteor.startup(), and just by chance a change in the app made my startup() code run before this package's startup() and hence was overruled.
The text was updated successfully, but these errors were encountered:
I was wondering why my automatic browser language detection code wasn't working anymore. Tracing the TAPi18n.setLanguage() calls, I finally found out that this package was responsible for setting the language back to English.
Responsible for this behaviour is this line:
https://github.com/TAPevents/tap-i18n-ui/blob/master/i18n_ui_amplify.coffee#L12
I think it's a silly decision to brute-force set the language to the first language available. Why don't you just choose the language that TAPi18n itself reports by TAPi18n.getLanguage() instead? This wouldn't break custom code that ran before. Not everyone wants to use a default language for any user.
At least this behaviour should be clearly documented, especially if it is a breaking change.
In my case, I was setting the language in an Meteor.startup(), and just by chance a change in the app made my startup() code run before this package's startup() and hence was overruled.
The text was updated successfully, but these errors were encountered: