Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes i18Find() on meteor 1.2 #20

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

phowat
Copy link

@phowat phowat commented Sep 22, 2015

I experienced the same issue described in #19 after updating to Meteor 1.2 . Looking into the issue, I noticed it failed because conf.supported_languages was null. Since getLanguages() worked in the same context, I added that.

@phowat
Copy link
Author

phowat commented Sep 22, 2015

I'm sorry. I was unaware that if I pushed more commits into my fork's master branch they would show up here. But the same issue from i18nFind() was happening to isSupportedLanguage().

@vuongngo
Copy link

Thanks @phowat . It works :)

@pmoons
Copy link

pmoons commented Jan 13, 2016

Works! Thanks @phowat

@Szayet
Copy link

Szayet commented Feb 6, 2016

@phowat I saw you created a working Atmosphere fork till we are waiting. Could you please look at the #24 and it's solution and maybe include it in your fork? Thanks in advance!

@janat08
Copy link

janat08 commented May 19, 2016

Maybe get the author to add some1 as contributor as this is dead for almost a year.

@krishaamer
Copy link

Thanks @phowat !

@krishaamer
Copy link

Can this be merged please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants