Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: activate rxnNotes field in Human-GEM #274

Merged
merged 2 commits into from
Jul 9, 2021

Conversation

haowang-bioinfo
Copy link
Member

Main improvements in this PR:

I hereby confirm that I have:

  • Tested my code on my own computer for running the model
  • Passed testYamlConversion check
  • Selected develop as a target branch

- Add `rxnNotes` field with following code:
ihuman.rxnNotes = ihuman.rxns;
ihuman.rxnNotes(:) = {''};
Copy link
Member

@mihai-sysbio mihai-sysbio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! This will enable further cleanup of the references. Some additional questions:

  • should this field be made visible on Metabolic Atlas?
  • can the COBRA toolbox read this field from the yml file?

@haowang-bioinfo
Copy link
Member Author

should this field be made visible on Metabolic Atlas?

This field is empty so far, so there is no point to make them visible now. Once they start to host useful information, then can be made visible IMO. A relevant question is "what information should be stored in this field?", which is added to #272.

can the COBRA toolbox read this field from the yml file?

Yes, COBRA toolbox supports this rxnNotes field.

@haowang-bioinfo haowang-bioinfo merged commit 1531a8a into develop Jul 9, 2021
@haowang-bioinfo haowang-bioinfo deleted the feat/addRxnNotes branch July 9, 2021 08:57
@haowang-bioinfo haowang-bioinfo mentioned this pull request Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants