[dx] keep tooling in one place #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 11, 2024
jrushlow
force-pushed
the
minor/phpstan-scripts
branch
from
ee9867b
to
e17038e
Compare
- `composer tools:run` runs `php-cs-fixer` & `phpstan` - `composer tools:run:php-cs-fixer` run only `php-cs-fixer` (works for `phpstan` as well). - `composer tools:upgrade` upgrades / installs all of the `tools/*` - `composer tools:upgrade:php-cs-fixer` Upgrades / installs only `php-cs-fixer` (works for `phpstan` as well)
jrushlow
force-pushed
the
minor/phpstan-scripts
branch
from
9ced413
to
e813bb1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
composer tools:runrunsphp-cs-fixer&phpstancomposer tools:run:php-cs-fixerrun onlyphp-cs-fixer(works forphpstanas well).composer tools:upgradeupgrades / installs all of thetools/*composer tools:upgrade:php-cs-fixerUpgrades / installs onlyphp-cs-fixer(works forphpstanas well)This PR does not remove the
phpstan/phpstanfrom the maincomposer.json. PHPUnit tests are dependent on a phpstan testcase. As such, the "main"phpstan/phpstaninvendor/is used for tests & the "tools/phpstan" is used for static analysis consistent with the rest of SymfonyCasts.We need to handle the PHPStan test case (and failures) in a separate PR