Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dont depend on phpstan as project dependency #7

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Conversation

jrushlow
Copy link
Contributor

@jrushlow jrushlow commented Jun 11, 2024

Implementing tools/phpstan in say reset-password-bundle, so we can remove the dependency requirement in the project's composer.json (require-dev), causes the test suite to blow up. our global phpstan CI run looks for vendor/bin/phpstan. This changes it to tools/phpstan/vendor/bin/phpstan .


Review / update these repos if they're using phpstan as a project dependency (implement tools/* & composer scripts)

@jrushlow
Copy link
Contributor Author

We need to merge this first before we can merge the dependent PR's.

@jrushlow jrushlow merged commit dda27dc into main Jun 11, 2024
@jrushlow jrushlow deleted the phpstan-own-dir branch June 11, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant