diff --git a/src/editor/object_option.cpp b/src/editor/object_option.cpp index 647984e06c2..9b8fce64a92 100644 --- a/src/editor/object_option.cpp +++ b/src/editor/object_option.cpp @@ -412,7 +412,7 @@ FileObjectOption::FileObjectOption(const std::string& text, std::string* pointer std::vector filter, const std::string& basedir, bool path_relative_to_basedir, - std::vector additional_filter, + const std::vector& additional_filter, unsigned int flags) : ObjectOption(text, key, flags), m_pointer(pointer), @@ -420,7 +420,7 @@ FileObjectOption::FileObjectOption(const std::string& text, std::string* pointer m_filter(std::move(filter)), m_basedir(basedir), m_path_relative_to_basedir(path_relative_to_basedir), - m_additional_filter(std::move(additional_filter)) + m_additional_filter(additional_filter) { } diff --git a/src/editor/object_option.hpp b/src/editor/object_option.hpp index c1a43f59e6f..81679a03ac0 100644 --- a/src/editor/object_option.hpp +++ b/src/editor/object_option.hpp @@ -280,7 +280,7 @@ class FileObjectOption : public ObjectOption std::vector filter, const std::string& basedir, bool path_relative_to_basedir, - std::vector additional_filter = {}, + const std::vector& additional_filter = {}, unsigned int flags = 0); virtual void save(Writer& write) const override; @@ -291,9 +291,9 @@ class FileObjectOption : public ObjectOption std::string* const m_pointer; std::optional m_default_value; const std::vector m_filter; - const std::vector m_additional_filter; std::string m_basedir; bool m_path_relative_to_basedir; + const std::vector m_additional_filter; private: FileObjectOption(const FileObjectOption&) = delete;