From 1149313a1bc2c8d2538fbf8540c513b819bb9816 Mon Sep 17 00:00:00 2001 From: Vankata453 <78196474+Vankata453@users.noreply.github.com> Date: Sun, 6 Aug 2023 03:00:26 +0300 Subject: [PATCH] Use unsigned integers for storing progress --- src/supertux/menu/world_set_menu.cpp | 2 +- src/supertux/savegame.cpp | 4 ++-- src/supertux/savegame.hpp | 6 +++--- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/supertux/menu/world_set_menu.cpp b/src/supertux/menu/world_set_menu.cpp index 93d358062d5..0aa9472cad4 100644 --- a/src/supertux/menu/world_set_menu.cpp +++ b/src/supertux/menu/world_set_menu.cpp @@ -29,7 +29,7 @@ WorldSetMenu::WorldSetMenu() // Add Story Mode entry. // Story Mode should not have its progress shown. - add_world(_("Story Mode"), "levels/world1", { -1, -1 }, find_preview("previews/world1.png", "levels/world1")); + add_world(_("Story Mode"), "levels/world1", { 0, 0 }, find_preview("previews/world1.png", "levels/world1")); add_entry(1, _("Contrib Levels")); add_hl(); diff --git a/src/supertux/savegame.cpp b/src/supertux/savegame.cpp index 2dd09d95c1e..0f324a8d090 100644 --- a/src/supertux/savegame.cpp +++ b/src/supertux/savegame.cpp @@ -98,10 +98,10 @@ LevelsetState::get_level_state(const std::string& filename) const } } -int +uint32_t Savegame::Progress::get_percentage() const { - return solved > 0 ? static_cast(static_cast(solved) / total * 100) : 0; + return solved > 0 ? static_cast(static_cast(solved) / static_cast(total) * 100) : 0; } std::unique_ptr diff --git a/src/supertux/savegame.hpp b/src/supertux/savegame.hpp index 9e6533cc546..ddc208a940e 100644 --- a/src/supertux/savegame.hpp +++ b/src/supertux/savegame.hpp @@ -78,10 +78,10 @@ class Savegame final solved(solved_), total(total_) {} - int solved; - int total; + uint32_t solved; + uint32_t total; - int get_percentage() const; + uint32_t get_percentage() const; }; public: