Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entangled units #312

Merged
merged 38 commits into from
Sep 3, 2024
Merged

Entangled units #312

merged 38 commits into from
Sep 3, 2024

Conversation

ddahlbom
Copy link
Member

@ddahlbom ddahlbom commented Sep 2, 2024

Adds basic "entangled units" functionality to Sunny. Usable with existing optimization, classical dynamics and spin wave code. The functionality is sufficient for basic examples and is not yet public facing. The system creation function can only be accessed as Sunny.EntangledSystem.

While this is safe as a non-public feature, the following steps remain:

  1. Fill out test suite
  2. Test on systems with units larger than dimers
  3. Stress test reshaping
  4. Finish the program of incorporating position information in the MeasureSpec so the EntangledSpinWaveTheory can be reduced to an ordinary SpinWaveTheory. This will reduce code duplication.

@kbarros kbarros merged commit 216cc5d into main Sep 3, 2024
4 checks passed
@kbarros kbarros deleted the entangled-units branch September 3, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants