Add GitHub authentication #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echlebek
reviewed
Jul 10, 2024
install-script/test/consts_common.go
Outdated
Comment on lines
24
to
25
| fmt.Println("Error: GitHub token not found in environment variables") | ||
| os.Exit(1) |
There was a problem hiding this comment.
You can use log.Fatal here, FYI
echlebek
requested changes
Jul 10, 2024
Comment on lines
71
to
72
| - name: Debug GitHub Token | ||
| run: echo "Token is ${{ secrets.GH_CI_TOKEN }}" |
There was a problem hiding this comment.
This should be removed, and we should change the token afterwards
echlebek
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will help in making request to github after authentication. Related issue