Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows service does not specify LoadOrderGroup #116

Open
echlebek opened this issue Sep 20, 2024 · 1 comment
Open

Windows service does not specify LoadOrderGroup #116

echlebek opened this issue Sep 20, 2024 · 1 comment

Comments

@echlebek
Copy link
Contributor

The packaging for the Windows collector does not specify DNSClient as part of the LoadOrderGroup (see https://wixtoolset.org/docs/schema/wxs/serviceinstall/#attributes)

It seems that this can lead to the collector not being able to bind to localhost when it starts up, since DNS is not yet available.

While this can likely be worked around by specifying 127.0.0.1 as the bind address, we should make sure the collector does not try to start before DNS is available.

@amdprophet
Copy link
Contributor

In order to fix this, I think we need to add a ServiceDependency as a child to the existing ServiceInstall element: https://wixtoolset.org/docs/schema/wxs/servicedependency/

The dependency can be a Group; I believe we should be depending on the NetworkProvider group which contains services such as DNS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants