Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: wait_function #400

Merged
merged 2 commits into from
Feb 19, 2024
Merged

fix: wait_function #400

merged 2 commits into from
Feb 19, 2024

Conversation

SdgJlbl
Copy link
Contributor

@SdgJlbl SdgJlbl commented Feb 19, 2024

Related issue

# followed by the number of the issue

Summary

Notes

Please check if the PR fulfills these requirements

  • If necessary, the changelog has been updated
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • The commit message follows the conventional commit specification
  • For any breaking changes, companion PRs have been opened on the following repositories:

@SdgJlbl
fix: wait_function
ce26250 
Signed-off-by: SdgJlbl <[email protected]>
@SdgJlbl SdgJlbl marked this pull request as ready for review February 19, 2024 10:47
@SdgJlbl SdgJlbl requested a review from a team as a code owner February 19, 2024 10:47
@SdgJlbl
fix: documentation
e5f49cf 
Signed-off-by: SdgJlbl <[email protected]>
guilhem-barthes
guilhem-barthes approved these changes Feb 19, 2024
View reviewed changes
Copy link
Contributor

@guilhem-barthes guilhem-barthes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SdgJlbl SdgJlbl merged commit f0d19e7 into main Feb 19, 2024
6 checks passed
@SdgJlbl SdgJlbl deleted the fix/wait_function branch February 19, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guilhem-barthes guilhem-barthes guilhem-barthes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SdgJlbl @guilhem-barthes