fix: store asset failure report supports exception without logs #970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/e2e --tests sdk,substrafl |
|
End to end tests: ✔️ SUCCESS “To infinity and beyond!” ― Buzz Lightyear, Toy Story |
guilhem-barthes
changed the title
guilhem-barthes
changed the title
SdgJlbl
reviewed
Aug 13, 2024
| @@ -0,0 +1 @@ | |||
| Celery was failing silently when a task called `FailableTask.on_failure` if the task didn't have a `logs` attribute (now return internal error) | |||
There was a problem hiding this comment.
I don't think that the right changes folder :)
SdgJlbl
reviewed
Aug 13, 2024
Signed-off-by: Guilhem Barthés <[email protected]>
Signed-off-by: Guilhem Barthés <[email protected]>
Signed-off-by: Guilhem Barthés <[email protected]>
Signed-off-by: Guilhem Barthés <[email protected]>
Signed-off-by: Guilhem Barthés <[email protected]>
guilhem-barthes
force-pushed
the
fix/store_asset_failure_report-supports-exception-without-logs
branch
from
b4c863c
to
35b289f
Compare
Signed-off-by: Guilhem Barthés <[email protected]>
guilhem-barthes
deleted the
fix/store_asset_failure_report-supports-exception-without-logs
branch
guilhem-barthes
restored the
fix/store_asset_failure_report-supports-exception-without-logs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes Fl-1689
How has this been tested?
Checklist