Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wait init migrations lack env var #929

Merged
merged 2 commits into from
Jun 10, 2024

Conversation

guilhem-barthes
Copy link
Contributor

Description

Fixes FL-1589

How has this been tested?

Checklist

  • changelog was updated with notable changes
  • documentation was updated

…TUP_PENDING_STATE_WAIT_SECONDS` in all pods

Signed-off-by: Guilhem Barthés <[email protected]>
@guilhem-barthes
Copy link
Contributor Author

/e2e --tests sdk,substrafl

@Owlfred
Copy link

Owlfred commented Jun 10, 2024

End to end tests: ❌ FAILURE

Jobs status:

Oh noes.

@guilhem-barthes guilhem-barthes changed the title Fix/wait init migrations lack env var fix: wait init migrations lack env var Jun 10, 2024
Signed-off-by: Guilhem Barthés <[email protected]>
@guilhem-barthes guilhem-barthes force-pushed the fix/wait-init-migrations-lack-env-var branch from 1d74dba to 0cea3a9 Compare June 10, 2024 11:10
@guilhem-barthes
Copy link
Contributor Author

/e2e --tests sdk,substrafl,documentation

@Owlfred
Copy link

Owlfred commented Jun 10, 2024

End to end tests: ✔️ SUCCESS

Awesome! 🎉

@guilhem-barthes
Copy link
Contributor Author

@guilhem-barthes guilhem-barthes marked this pull request as ready for review June 10, 2024 11:39
@guilhem-barthes guilhem-barthes requested a review from a team as a code owner June 10, 2024 11:39
Copy link
Contributor

@thbcmlowk thbcmlowk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@SdgJlbl SdgJlbl merged commit fe7ddca into main Jun 10, 2024
7 checks passed
@SdgJlbl SdgJlbl deleted the fix/wait-init-migrations-lack-env-var branch June 10, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants