-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: resources in separate yaml #903
Conversation
try: | ||
requests = resources_dict["requests"] | ||
except KeyError: | ||
requests = None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
try: | |
requests = resources_dict["requests"] | |
except KeyError: | |
requests = None | |
requests = resources_dict.get("requests", None) |
try: | ||
limits = resources_dict["limits"] | ||
except KeyError: | ||
limits = None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
try: | |
limits = resources_dict["limits"] | |
except KeyError: | |
limits = None | |
limits = resources_dict.get("limits", None) |
13951d5
to
e9325ed
Compare
@@ -28,6 +28,7 @@ deploy: | |||
chartPath: charts/substra-backend | |||
valuesFiles: | |||
- examples/values/backend-org-1.yaml | |||
- charts/substra-backend/resources.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure I am following. Is it not prod values that are in the resources.yaml
file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The values are the ones that we currently apply by default. It is up to us to decide if we put prod values (so with highest requests) or if we want to keep these low requests. Also, il was to test that it was working as expected. We can also completely remove it from skaffold but I don't know how to ensure that this file stay up to date with CI
Signed-off-by: ThibaultFy <[email protected]>
dc145b9
to
eee1ada
Compare
close in favor of #907 |
Description
part of FL-1562
How has this been tested?
Resources are tested by being injected in org-1 with skaffold
Checklist