Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ci): refactor helm GHA workflow #771

Merged
merged 2 commits into from
Feb 16, 2024
Merged

refactor(ci): refactor helm GHA workflow #771

merged 2 commits into from
Feb 16, 2024

Conversation

kaanyagci
Copy link
Contributor

@kaanyagci kaanyagci commented Oct 19, 2023 •
edited
Loading

Description

Closes FL-1240

Added

  • Checking if Chart.lock file is also updated

Changed

  • Existing helm GitHub Action workflow refactored to use substra/substra-gha-workflows/.github/workflows/helm.yml.

How has this been tested?

Checklist

  • changelog was updated with notable changes
  • documentation was updated

@kaanyagci kaanyagci force-pushed the refactor/common-gha-workflows branch 4 times, most recently from bc3c21b to fd978f9 Compare October 19, 2023 14:40
@kaanyagci kaanyagci self-assigned this Oct 19, 2023
@kaanyagci kaanyagci force-pushed the refactor/common-gha-workflows branch from ab8c0cd to f0563ad Compare October 19, 2023 15:16
@kaanyagci kaanyagci changed the title refactor(ci): refactor Helm GHA workflow refactor(ci): refactor common GHA workflows Oct 19, 2023
@kaanyagci kaanyagci force-pushed the refactor/common-gha-workflows branch from cd3b85b to fa5c75f Compare October 19, 2023 23:20
@kaanyagci kaanyagci force-pushed the refactor/common-gha-workflows branch 2 times, most recently from 0c82296 to fceb5c4 Compare November 3, 2023 07:54
@kaanyagci kaanyagci marked this pull request as ready for review November 3, 2023 08:18
@kaanyagci kaanyagci requested a review from a team as a code owner November 3, 2023 08:18
@kaanyagci kaanyagci marked this pull request as draft November 3, 2023 08:19
@kaanyagci kaanyagci changed the title refactor(ci): refactor common GHA workflows refactor(ci): refactor common GHA workflows test Nov 3, 2023
@kaanyagci kaanyagci force-pushed the refactor/common-gha-workflows branch 3 times, most recently from fceb5c4 to 3bafd6b Compare November 5, 2023 21:50
@kaanyagci kaanyagci changed the title refactor(ci): refactor common GHA workflows test refactor(ci): refactor helm GHA workflow Nov 5, 2023
@kaanyagci kaanyagci added the github_actions Pull requests that update GitHub Actions code label Nov 5, 2023
@kaanyagci kaanyagci marked this pull request as ready for review November 5, 2023 21:58
@kaanyagci kaanyagci enabled auto-merge (squash) November 5, 2023 22:48
oleobal
oleobal reviewed Nov 7, 2023
View reviewed changes
.github/workflows/helm.yml Outdated Show resolved Hide resolved
@linear Linear
Copy link

linear bot commented Jan 15, 2024

FL-1240 PR validation does not enforce helm dependency update

@kaanyagci kaanyagci force-pushed the refactor/common-gha-workflows branch 2 times, most recently from d4c6092 to e56848c Compare February 6, 2024 13:38
@kaanyagci
Copy link
Contributor Author

e56848c refactors the conventional_pr GHA workflow to substra-gha-workflows repository. This changes the conventional_title workflow to Conventional PR title / conventional_title / conventional_title. As the conventional_title workflow is set as required, it hangs as it no longer exists. We need to change the required workflow or drop that commit.

@kaanyagci kaanyagci force-pushed the refactor/common-gha-workflows branch from a0bf89c to e56848c Compare February 6, 2024 13:56
@oleobal
Copy link
Contributor

oleobal commented Feb 6, 2024

Tagging @Substra/code-owners since otherwise they won't get notified ^^

@kaanyagci kaanyagci marked this pull request as draft February 8, 2024 09:13
auto-merge was automatically disabled February 8, 2024 09:13

Pull request was converted to draft

@kaanyagci kaanyagci force-pushed the refactor/common-gha-workflows branch from 9348292 to e56848c Compare February 8, 2024 09:58
@kaanyagci kaanyagci mentioned this pull request Feb 13, 2024
Closed
2 tasks
SdgJlbl
SdgJlbl approved these changes Feb 16, 2024
View reviewed changes
Copy link
Contributor

@SdgJlbl SdgJlbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work 🙏

@kaanyagci kaanyagci marked this pull request as ready for review February 16, 2024 15:57
@kaanyagci kaanyagci merged commit bb48af9 into main Feb 16, 2024
6 checks passed
@kaanyagci kaanyagci deleted the refactor/common-gha-workflows branch February 16, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleobal oleobal oleobal left review comments

@SdgJlbl SdgJlbl SdgJlbl approved these changes

@thbcmlowk thbcmlowk Awaiting requested review from thbcmlowk

Assignees

@kaanyagci kaanyagci

Labels
github_actions Pull requests that update GitHub Actions code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kaanyagci @oleobal @SdgJlbl