-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for issue #1070 - Autocomplete for \cite{} and \ref{} looks in open buffers too #1071
Open
Aligorith
wants to merge
3
commits into
SublimeText:master
Choose a base branch
from
Aligorith:Fix1070_CiteRefFromOpenBuffers
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -55,14 +55,29 @@ def find_labels_in_files(root, labels): | |
labels.append(command.args) | ||
|
||
|
||
# grab labels from all open buffers too | ||
def find_labels_in_open_files(views, labels): | ||
for view in views: | ||
# XXX: Hardcoded to only look for tex files, so that it doesn't try | ||
# looking for label commands in support files | ||
if view.file_name() is None or view.file_name().endswith(".tex"): | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This could probably be more sensibly implemented by checking the syntax (something like |
||
view.find_all(r'\\label\{([^\{\}]+)\}', 0, '\\1', labels) | ||
|
||
|
||
# get_ref_completions forms the guts of the parsing shared by both the | ||
# autocomplete plugin and the quick panel command | ||
def get_ref_completions(view): | ||
completions = [] | ||
# Check the file buffer first: | ||
# 1) in case there are unsaved changes | ||
# 2) if this file is unnamed and unsaved, get_tex_root will fail | ||
view.find_all(r'\\label\{([^\{\}]+)\}', 0, '\\1', completions) | ||
find_labels_in_open_files([view], completions) | ||
|
||
# Check all other open buffers too: | ||
# 1) for the same reasons as above | ||
# 2) in case the project isn't set up to build in Sublime | ||
for window in sublime.windows(): | ||
find_labels_in_open_files(window.views(), completions) | ||
|
||
root = getTeXRoot.get_tex_root(view) | ||
if root: | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer that the default option was to search the active window only since its possible to have multiple unrelated TeX documents open at the same time.