From a21388dbcb1467df016360debbd8ac43f856f051 Mon Sep 17 00:00:00 2001 From: Vladyslav Sitalo Date: Sat, 30 May 2020 16:52:37 -0700 Subject: [PATCH] Make config_settings_spec more future proof against new settings --- test/config/config_settings_spec.py | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/test/config/config_settings_spec.py b/test/config/config_settings_spec.py index 1164a62..3b5551a 100644 --- a/test/config/config_settings_spec.py +++ b/test/config/config_settings_spec.py @@ -1,8 +1,7 @@ -import logging +from unittest.mock import MagicMock +from expects import expect, contain from mamba import describe, it, context -from unittest.mock import MagicMock -from random import shuffle from test_utils.anki import mock_anki_modules @@ -11,7 +10,6 @@ from crowd_anki.config.config_settings import ConfigSettings, NoteSortingMethods - with describe(ConfigSettings) as self: with context("someone interacts with any config setting"): with it("do not sort / sort by none"): @@ -87,12 +85,12 @@ "import_notes_ignore_deck_movement": True } - config = ConfigSettings(addon_manager=addon_manager_mock, init_values=old_settings) + config = ConfigSettings(addon_manager_mock, old_settings, MagicMock()) for key in new_settings: setattr(config, key, new_settings[key]) config.save() - assert config._config == new_settings + expect(config._config.items()).to(contain(*list(new_settings.items()))) addon_manager_mock.writeConfig.assert_called_once()