Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add claim module timing variables as module parameters #734

Open
sampocs opened this issue Apr 21, 2023 · 0 comments
Open

Add claim module timing variables as module parameters #734

sampocs opened this issue Apr 21, 2023 · 0 comments

Comments

@sampocs
Copy link
Collaborator

sampocs commented Apr 21, 2023

Background

Claim module parameters are defined here, but they're not actually stored in the state as true module parameters. A consequence of this is that we cannot easily modify the parameters for unit or integration tests.

Suggested Design

  • Rename DefaultVestingInitialPeriod to DefaultInitialPeriodDuration
  • Rename DefaultEpochDuration to DefaultSubsequentPeriodDuration
  • Store both of those as module parameters:
    • Add them to the params proto
    • Set them in InitGenesis
    • Set them in upgrade handler
  • Modify any functions that leverage those values to read them from the store and access them from the params struct
  • Change the init_chain.sh script in dockernet to sed & replace the default values with 120 seconds for the DefaultInitialPeriodDuration, and 60 seconds for the DefaultSubsequentPeriodDuration

Acceptance Criteria

  • Unit tests and integration tests pass
  • Airdrop integration test scripts pass
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant