Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beautify the cryptocurrency page #305

Open
karthiknadar1204 opened this issue Jun 20, 2023 · 10 comments
Open

Beautify the cryptocurrency page #305

karthiknadar1204 opened this issue Jun 20, 2023 · 10 comments
Assignees

Comments

@karthiknadar1204
Copy link

In my proposed solution, Since the data about the coins is being fetched via an API, we could add individual cards for each coin , each card will contain the logo of the coin, a name below the logo and we seem to be presenting 7 different details for each coin, we could place these seven details beautifully in the cards along with pagination making only up to 25 to 30 cards visible on one page.

We could Add hover effects to the cards along with box shadow and a view button so if anyone clicks on the cards, the graph of the coin is fetched and the details are now visible on a much larger card about the width of the screen which includes the graphs of the coin and all the details we were previously fetching from the API.

We could make the TradingView snaps carousel dynamic , like the carousel will move automatically to the right and short span of time, simultaneously the user will also have the option to tweak the carousel

@karthiknadar1204
Copy link
Author

karthiknadar1204 commented Jun 20, 2023

I would like to work on this issue under gssoc'23 @royalpinto007

@royalpinto007
Copy link
Member

Hi @karthiknadar1204,
Please submit a PR with before and after screenshots.
Thanks!

@karthiknadar1204
Copy link
Author

Perfect, Thank you

@karthiknadar1204
Copy link
Author

@royalpinto007 Is it fine if i use the coingecko API to fetch data, it is much more diverse in the contents it has to offer, will try the existing API as well before arriving at an conclusion

@royalpinto007
Copy link
Member

No issues!

@karthiknadar1204
Copy link
Author

Have started the work, will try to share the preview of the page by tomorrow
Thank you

@royalpinto007
Copy link
Member

Yeah man, no worries!

@karthiknadar1204
Copy link
Author

@royalpinto007 I have fetched the coin details onto the page using the coingecko API, as a temporary measure can I use vanilla CSS for styling the cards, I believe the project has been prominently using tailwind classes for styling so thought should inform you once, fine?

@karthiknadar1204
Copy link
Author

@royalpinto007 I am done with the issue, have to make some responsiveness, can you have someone else add the responsive behaviour in a separate issue, I have created a basic skeleton of the contents from the API that includes the graohs and a lot more and have added some primary styling but having some clashes.

@karthiknadar1204
Copy link
Author

I'll share the preview in a bit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants