Minor errors in formalicious.class.php

[patrickatwsrn]

While tracking down an issue in formalicious (#27), I found this inside my modx error log:

[2023-05-10 10:07:55] (ERROR @ /var/www/vhosts/*******/httpdocs/modx/core/components/formalicious/model/formalicious/formalicious.class.php : 122) PHP warning: Undefined array key "branding_url_help"
[2023-05-10 10:07:55] (ERROR @ /var/www/vhosts/*******/httpdocs/modx/core/components/formalicious/model/formalicious/formalicious.class.php : 122) PHP warning: Undefined array key "branding_url_help"
[2023-05-10 10:07:55] (ERROR @ /var/www/vhosts/*******/httpdocs/modx/core/components/formalicious/model/formalicious/formalicious.class.php : 220) PHP warning: Undefined array key "corePath"

[patrickatwsrn]

2do: New issue for wrong version number in core/components/formalicious/model/formalicious/formalicious.class.php

Formalicious/core/components/formalicious/model/formalicious/formalicious.class.php

Line 53 in 8ebad78

'version' => '2.0.3',

Shouldn't this be 2.0.5 instead of 2.0.3 ?

[patrickatwsrn]

https://github.com/Sterc/Formalicious/blob/8ebad78bc9d1e3fa7847161347066ab500a2d3c0/core/components/formalicious/model/formalicious/formalicious.class.php

2do branding_help_url !== branding_url_help

Line 55 sets the key to branding_help_url

'branding_help_url' => $this->modx->getOption('formalicious.branding_url_help'),

BUT line 85 asks for branding_url_help

$url = $this->getOption('branding_url_help');

[patrickatwsrn]

And another one:

Line 40 creates a key for core_path

'core_path' => $corePath,

BUT line 220 is looking for corePath

$pubKeyFile = $this->config['corePath'] . '.pubkey';