Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Добавлен Directory.Build.props +semver:skip #113

Merged
merged 16 commits into from
Sep 16, 2024

Conversation

Keyros
Copy link
Contributor

@Keyros Keyros commented Sep 15, 2024

Description

Перешли на CPM.
Начали использовать Directory.Build.props.
Удалили ссылку на System.Text.Json из HydraScript.Infrastructure.LexerRegexGenerator.

Related Issues

#74 #112

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • I have added corresponding labels with respect to the part of the interpreter i've worked on.

Copy link

github-actions bot commented Sep 15, 2024

File Coverage Branches Missing
All files 44% 43%

Minimum allowed coverage is 20%

Generated by 🐒 cobertura-action against 73069e7

@Keyros Keyros changed the title Users/rke/centralizing configuration Добавлен Directory.Build.props Sep 15, 2024
Copy link
Owner

@Stepami Stepami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Отличная работа! Даже не ожидал, что есть package пропсы! Спасибо!

tests/Directory.Build.props Show resolved Hide resolved
ExtendedJavaScriptSubset.sln Outdated Show resolved Hide resolved
@Stepami Stepami changed the title Добавлен Directory.Build.props Добавлен Directory.Build.props +semver:skip Sep 16, 2024
@Stepami Stepami self-requested a review September 16, 2024 16:59
Copy link
Owner

@Stepami Stepami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Stepami Stepami merged commit a9d289a into Stepami:master Sep 16, 2024
2 checks passed
@Keyros Keyros deleted the users/rke/centralizing-configuration branch September 16, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants