Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mail templates do not accept the string " or " #137

Open
kpabijanskas opened this issue Jun 9, 2016 · 2 comments
Open

Mail templates do not accept the string " or " #137

kpabijanskas opened this issue Jun 9, 2016 · 2 comments

Comments

@kpabijanskas
Copy link

Hi A2billing devs,

We are using v2.2.0.

This can be reproduced every time.

If the string " or " (without the quotes, with spaces on both sides) appears in a mail template, when saving, it will get cut out of the template before being saved to the database. This only happens when there are spaces on both sides of the word "or" (not when there is only a space on one side).

Thanks.

@dcitelecom
Copy link

strings " if " and " or " are stripped when email is sent. Doesn't like apostrophe " ' " either. Makes it very difficult to write a proper sentence.

@sbosio
Copy link

sbosio commented Nov 11, 2017

This seems to be related to sanitization of strings before inserting data into the SQL database, in order to prevent code (specifically SQL) injection, but it's known to be a bad implementation of sanitization. Worst, it doesn't works either, as it can be bypassed. See: https://0x4148.com/2016/10/28/a2billing-rce/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants