Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Update Release Workflow to Build & Push for ARM64 #1105

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

kdavis
Copy link
Contributor

@kdavis kdavis commented Jun 28, 2024

Sorry about the delay

I joined the pushing of tags into the build-push-action, and left the STABLE_VERSION on its own step. (Replicating the changes made in #1100)

Let me know if any concerns :)

@SebastianStehle SebastianStehle merged commit 39c540d into Squidex:master Jul 3, 2024
2 checks passed
@SebastianStehle
Copy link
Contributor

I just tried it and it does not work. Because the tags do not match.

@kdavis
Copy link
Contributor Author

kdavis commented Jul 10, 2024

One thought is to do a ternary on the stable version, and append the latest if it's true

          tags: squidex/squidex:${{ env.GITHUB_REF_SLUG }},squidex/squidex:${{ steps.version.outputs._0 }}{{env.STABLE_VERSION == 'true' && ',squidex/squidex:latest'}}
      - name: Publish - Build & Push for Multi-Platforms
        uses: docker/[email protected]
        with:
          build-args: "SQUIDEX__BUILD__VERSION=${{ env.GITHUB_REF_SLUG }},SQUIDEX__RUNTIME__VERSION=${{ env.GITHUB_REF_SLUG }}"
          cache-from: type=gha
          cache-to: type=gha,mode=max
          platforms: linux/amd64,linux/arm64
          tags: squidex/squidex:${{ env.GITHUB_REF_SLUG }},squidex/squidex:${{ steps.version.outputs._0 }}${{env.STABLE_VERSION == 'true' && ',squidex/squidex:latest' || ''}}
          push: ${{ github.event_name != 'pull_request' }

@SebastianStehle
Copy link
Contributor

Yes, this could works as well. I have just reverted it for now. What was the reason for this change again?

@kdavis
Copy link
Contributor Author

kdavis commented Jul 10, 2024

It was to align it to be more like the dev workflow, like here: #1100

@SebastianStehle
Copy link
Contributor

My approach also failed, due to other reasons, so I test your fix now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants