Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Companion image shows incomplete code for method #51

Open
offray opened this issue Feb 6, 2020 · 2 comments
Open

Companion image shows incomplete code for method #51

offray opened this issue Feb 6, 2020 · 2 comments

Comments

@offray
Copy link

offray commented Feb 6, 2020

  • page: 41
  • version: master @ 0638b16 (PDF)

While the text on the page is complete showing this:

MyExampleSetTest >> testRemove
  | full |
  full := Set with: 5 with: 6.
  full remove: 5.
  self assert: (full includes: 6).
  self deny: (full includes: 5)

The companion image (6.1) on the same page, shows the complete code without the first two lines, as shown here:

which can be a little confusing, when the learner is reading and finds the image not fully including the method source, despite of having space for that. Would be advisable to include a screenshot with the complete source of the method. I have provided it here:

@SergeStinckwich
Copy link
Member

Can you do a PR instead?

@offray
Copy link
Author

offray commented Feb 6, 2020

Not at the moment. I'm reading the book in a quick way, and would not have time for dealing directly with the book source code and learning Pillar markup. I will keep reporting issues and if I have time and they have not being solved, I'll try doing PR to solve them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants