Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Folder Naming Scheme #30

Open
GregoryGHarding opened this issue Feb 29, 2024 · 4 comments
Open

Folder Naming Scheme #30

GregoryGHarding opened this issue Feb 29, 2024 · 4 comments

Comments

@GregoryGHarding
Copy link

can we please add a leading zero to single digit episode/season numbers. its a pain to deal with otherwise

@cawnj
Copy link
Collaborator

cawnj commented Mar 3, 2024

The season folder name scheme is the default generated by tinyMediaManager (which is what we used to manage the .nfo files and episode metadata).

The plex naming scheme here does use leading zeroes in season folder names, and for sure it is definitely useful when viewing your files on disk.
In terms of how Plex handles it - Plex doesn't care, it will sort the seasons correctly with or without leading zeroes.

I just did a test and can confirm we'd need code changes to accomodate this and we'd require every contributor to change one of the default settings in tinyMediaManager also.

My opinions are not strong here but I don't think it's worth the trouble. I can be convinced otherwise though!


@GregoryGHarding Any particular reasons why this would be beneficial other than following plex's naming conventions more strictly?

@SpykerNZ Any input/thoughts here?

@SpykerNZ
Copy link
Owner

SpykerNZ commented Mar 4, 2024

If I am understanding this correct, you want to add a prefix 0 to single digit episode/folders inside the nfo files? And then also update the folder names on disk?

I don't have a strong preference either way. If someone wanted to implemented this I wouldn't be opposed to it.

My only requirement would be this having backwards compatibility with the current naming conventions. This could be solved programmatically, such as adding an upgrade step in the script appending the prefixes to the nfo's where required automatically (or something similar). Thus users extending their library with new nfos would get this update automatically.

Regarding the tinyMediaManager settings, I'm sure we could upload them to the repo somehow for contributors to import. Or just update the PR template with instructions on updating the app settings.

The folders on disk could also be renamed, as a first step towards this. Code changes would be pretty straight forward to support this, and wouldn't need any tweaks to tinyMediaManager. As above we would want to have back compatibility for the old folder naming convention, while supporting the new naming convention as the default.

@GregoryGHarding
Copy link
Author

GregoryGHarding commented Apr 18, 2024

i dont know what the intricacies of this is, but what im proposing is to have the Folders add the leading Zero to single digit seasons.

as of right now:

  • the folders are single digit
  • the posters are already leading zero,
  • the nfos are already leading zero
  • the media filenames are renamed to leading zero.

having the folders single digit breaks sorting and is the outlier in naming scheme/formatting.

@SpykerNZ
Copy link
Owner

If we are just adding a leading zero to the single digit folders I agree with this in principle. Anyone who feels like they want this could add it, as long as it is backward compatible with the existing structure + works with .nfo generation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants