Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for rodiojack backend. #1281

Merged
merged 2 commits into from
Jul 10, 2024
Merged

Add support for rodiojack backend. #1281

merged 2 commits into from
Jul 10, 2024

Conversation

agdphd
Copy link
Contributor

@agdphd agdphd commented Apr 29, 2024

The underlying librespot library already supports the JACK audio backend via rodio. Enabling it in spotifyd turns out to be dead simple--just needed to add the config enum elements to pass it through!

NOTE: I have tested this on my machine running Debian testing ("trixie"). The documentation for Fedora is based on the upstream docs for librespot: https://github.com/librespot-org/librespot/blob/329a1b16074af4d1a8abe2ed017b5d4a4a070ea1/COMPILING.md#audio-library-dependencies

Copy link
Member

@eladyn eladyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR! Only some small comments from my side.

src/config.rs Outdated Show resolved Hide resolved
src/config.rs Outdated Show resolved Hide resolved
@eladyn
Copy link
Member

eladyn commented May 7, 2024

And I fixed the clippy lints in #1282, so if could rebase your changes, that would be nice as well

The underlying `librespot` library already supports the JACK audio backend via `rodio`.
Enabling it in `spotifyd` turns out to be dead simple--just needed to add the config enum elements to pass it through!
@agdphd
Copy link
Contributor Author

agdphd commented Jun 1, 2024

Thanks for your review! Removed the spurious jackaudio references and rebased to current HEAD.

Copy link
Member

@eladyn eladyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you and sorry for taking so long for this simple PR!

@eladyn eladyn merged commit 8fb0b9a into Spotifyd:master Jul 10, 2024
getchoo added a commit to getchoo-contrib/nixpkgs that referenced this pull request Jul 12, 2024
this allows using the rodiojack backend added in
Spotifyd/spotifyd#1281
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants