Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require an expected status code for every request #225

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Require an expected status code for every request #225

wants to merge 4 commits into from

Conversation

axel-op
Copy link
Contributor

@axel-op axel-op commented May 10, 2020 •
edited
Loading

This PR:

  • Adds an expected status code for every call to request, and marks this parameter as required.
    Without it, the method silently fails, i.e. an object is returned with all values set to null...
  • Changes the preview header for the method create in pulls_service (the previous one was obsolete).
  • Deprecates most of the methods in orgs_service as the API has changed.
  • Updates multiple obsolete links to the documentation.

Fixes #194.
Fixes #230.

@axel-op axel-op changed the title Patch [pulls_service.create] Require an expected status code for every request May 30, 2020
@bsutton
Copy link
Contributor

bsutton commented Aug 13, 2020

I just raised an issue on this very topic then noticed your pr.

#230

Any chance this can be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CreateRelease asserting on auth error. Handle createHook errors
2 participants
@axel-op @bsutton