Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue.isOpen is case sensitive #401

Closed
Piinks opened this issue Apr 12, 2024 · 1 comment · Fixed by #402
Closed

Issue.isOpen is case sensitive #401

Piinks opened this issue Apr 12, 2024 · 1 comment · Fixed by #402
Labels
unreleased untriaged

Comments

@Piinks
Copy link
Contributor

Piinks commented Apr 12, 2024

Found in running https://github.com/flutter/cocoon/tree/main/dev/githubanalysis, the Issue.isOpen and isClosed getters expect all caps OPEN or CLOSED, but the value returned from Github is now lowercase.

Will file a PR, one sec. 😉
@github-actions GitHub Actions
Copy link

👋 Thanks for reporting! @robrbecker will take a look.

@Piinks Piinks mentioned this issue Apr 12, 2024
Merged
8 tasks
Piinks added a commit to Piinks/github.dart that referenced this issue Apr 12, 2024
@Piinks
Fix case sensitivity in Issue.[isOpen, isClosed]
2340355 
Fixes SpinlockLabs#401
@Piinks Piinks mentioned this issue Apr 12, 2024
Merged
robrbecker pushed a commit that referenced this issue Apr 13, 2024
@Piinks
Fix case sensitivity in Issue.[isOpen, isClosed] (#402)
8169398 
Fixes #401
auto-submit bot pushed a commit to flutter/cocoon that referenced this issue Apr 17, 2024
@Piinks
Updates to github analysis (#3637)
ff87767 
Adds link to updated spreadsheet.
Adds workaround for SpinlockLabs/github.dart#401
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
unreleased untriaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix case sensitivity in Issue.[isOpen, isClosed] Piinks/github.dart
1 participant
@Piinks