Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance ideas #24

Open
ferchaure opened this issue Feb 17, 2022 · 7 comments
Open

Enhance ideas #24

ferchaure opened this issue Feb 17, 2022 · 7 comments

Comments

@ferchaure
Copy link
Contributor

Hi Sam, I have a few people using the GUI, I will listen their comments and post them here.

  1. What do you think about adding checkbox similar to metric but for the properties of each unit? It should be easy to do but, I will appreciate some guide about how to code it.
@samuelgarcia
Copy link
Member

Hi Fernando,
cool thanks for the feedbakc.
yes I can do that.
If you want to try have look here : https://github.com/SpikeInterface/spikeinterface-gui/blob/main/spikeinterface_gui/unitlist.py#L133
Which property you want to have ?

@ferchaure
Copy link
Contributor Author

All the ones in sorting.get_property_keys() will be the best idea.

  1. We saw more issues with the line titlebar.setMaximumHeight(13) [in manwindow.py] all using QT5..., do you think we could add an if to increase the value to 20 when this version of QT is used?

@samuelgarcia
Copy link
Member

OK. This can be easy.

About the title bar size, it is also cool to keep little for laptop maybe we could make something adaptative depending the screen size/resolution
We could also think about some global property that could be saved in hidden config file.

Did you try using Pyside6 ?

@ferchaure
Copy link
Contributor Author

In some systems we couldn't install QT6, for that reason we are using QT5 and PyQT5.
We tried in laptops, and the text in titlebars are completely unreadable.
Does the method adjustSize adjust the widget size to show the text in it? Maybe this will be an alternative solution.

@samuelgarcia
Copy link
Member

OK
lets go for 20.
If no convinient on my side (linux+pyside6) I will do something adaptative later.

@ferchaure
Copy link
Contributor Author

At least for my system 20 is a god number, but on a mac system it looks a bit smaller (maybe a different screen resolution?). In my case (see the figure) you could get extra space reducing the separation between elements of each QDockWidget (red rectangles)... but I couldn't make it work

Untitled

@samuelgarcia
Copy link
Member

Hi Fernando.
Yes you are right. there must be also some kind of margin. I will have a look soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants