Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up incorrect and stale docker volumes automatically #1178

Open
dubbelosix opened this issue Nov 23, 2023 · 4 comments
Open

Clean up incorrect and stale docker volumes automatically #1178

dubbelosix opened this issue Nov 23, 2023 · 4 comments
Assignees
Labels
Small Use this label for quick cleanup and maintenance tasks

Comments

@dubbelosix
Copy link
Contributor

#1159 (comment)

So it seems like docker-compose is not re-creating the volumes. This could continue impacting users especially if they switch between demo-rollup in sovereign repo and starter-rollup since both of them use different credentials paths for the volume.

one simple fix is to just have the makefile detect and delete volumes every time (the credentials folder is very light weight. < 1kb)
another approach is to just use different volume names for both

@dubbelosix dubbelosix added the Small Use this label for quick cleanup and maintenance tasks label Nov 23, 2023
@dubbelosix dubbelosix self-assigned this Nov 23, 2023
@preston-evans98
Copy link
Member

I'd lean toward just deleting the volumes. That way things don't break when someone has two forks of a package

@zvolin
Copy link
Contributor

zvolin commented Nov 24, 2023

I'm not sure what is the way to reproduce this, however the credentials persists because the sequencer address is hardcoded

@zvolin
Copy link
Contributor

zvolin commented Nov 25, 2023

is there any reproduction from non mac-os? I started to think it's a bug in compose local volume driver specific to this system

@zvolin
Copy link
Contributor

zvolin commented Nov 28, 2023

hmm indeed if you have 2 different projects with the same docker layout and volume names, they will never be recreated so you have to either name it differently or delete them on the startup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Small Use this label for quick cleanup and maintenance tasks
Projects
None yet
Development

No branches or pull requests

3 participants