Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: include guzzle configuration when additionalConfigKeys is defined in provider #227

Merged

Conversation

kidager
Copy link
Contributor

@kidager kidager commented Feb 15, 2024

Fixes #228

Changes proposed in this pull request:

  • use array_merge instead of the union operator (+) to include guzzle configuration

@atymic atymic merged commit a67f194 into SocialiteProviders:master Feb 17, 2024
4 checks passed
Copy link

codecov bot commented Feb 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (35e15ed) 53.49% compared to head (d2b9ee1) 55.10%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #227      +/-   ##
============================================
+ Coverage     53.49%   55.10%   +1.60%     
  Complexity       78       78              
============================================
  Files            10       10              
  Lines           243      245       +2     
============================================
+ Hits            130      135       +5     
+ Misses          113      110       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with guzzle configuration
2 participants