Bump to laravel/socialite:^5.2 and phpunit/phpunit:^9.0 #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #222 +/- ##
=========================================
Coverage 53.49% 53.49%
Complexity 78 78
=========================================
Files 10 10
Lines 243 243
=========================================
Hits 130 130
Misses 113 113 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
atymic
reviewed
Aug 31, 2023
composer.json
Outdated
| "support": { | ||
| "issues": "https://github.com/socialiteproviders/manager/issues", | ||
| "source": "https://github.com/socialiteproviders/manager" | ||
| }, | ||
| "require": { | ||
| "php": "^8.0", | ||
| "illuminate/support": "^6.0 || ^7.0 || ^8.0 || ^9.0 || ^10.0", |
There was a problem hiding this comment.
May as well drop versions that dont support php 8 at least?
There was a problem hiding this comment.
Good idea, see 1bed9a3
atymic
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps some dependencies
laravel/socialite:^5.2as
$usesPKCEis already used in a few providers and depends on this versionphpunit/phpunit:^9.0as
^6.0does not support PHP<8