Fix asset hub fee #996
Merged
Fix asset hub fee #996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claravanstaden
force-pushed
the
clara/fix-assethub-fee
branch
from
2050f5a
to
b1aed23
Compare
alistair-singh
approved these changes
Nov 7, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #996 +/- ##
=======================================
Coverage 83.36% 83.36%
=======================================
Files 51 51
Lines 2044 2044
Branches 71 71
=======================================
Hits 1704 1704
Misses 325 325
Partials 15 15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
vgeddes
approved these changes
Nov 7, 2023
claravanstaden
force-pushed
the
clara/fix-assethub-fee
branch
from
b1aed23
to
1bd6e4d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The decimal precision in the tests do not match the decimals in the rococo runtime config. Using the
calculate_feetest to generate the user fee value for transfer token back to Ethereum, it generates a value that is too low.Polkadot-sdk companion: Snowfork/polkadot-sdk#21