Move beefy initialize params to construct

[yrong]

https://linear.app/snowfork/issue/SNO-567

[codecov]

Codecov Report

Patch coverage has no change and project coverage change: +1.76 🎉

Comparison is base (7b7a037) 65.50% compared to head (2d1d403) 67.27%.

❗ Current head 2d1d403 differs from pull request most recent head fe0d78b. Consider uploading reports for the commit fe0d78b to get more accurate results

Additional details and impacted files

@@                 Coverage Diff                 @@
##           proxy-contracts     #893      +/-   ##
===================================================
+ Coverage            65.50%   67.27%   +1.76%     
===================================================
  Files                   43       42       -1     
  Lines                 1754     1583     -171     
  Branches                70       70              
===================================================
- Hits                  1149     1065      -84     
+ Misses                 586      499      -87     
  Partials                19       19              

Flag	Coverage Δ
solidity	72.34% <ø> (+0.86%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
core/packages/contracts/src/BeefyClient.sol	75.00% <ø> (+2.50%)	⬆️

... and 13 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[vgeddes]

I prefer for DeployScript.sol to read the beefy init parameters from a JSON file. With this approach, we know exactly what the init parameters will be before we actually deploy the contracts. This is important for production.

See docs at https://book.getfoundry.sh/cheatcodes/parse-json?highlight=parseJson#how-to-use-stdjson

There is also an example in our codebase at

snowbridge/core/packages/contracts/test/MMRProof.t.sol

Line 35 in 7b7a037

fixtureData = vm.readFile(path).parseRaw("");

[vgeddes]

+1