Fix invalid dest fee #1148
Merged
Fix invalid dest fee #1148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1148 +/- ##
==========================================
+ Coverage 78.81% 78.92% +0.10%
==========================================
Files 13 13
Lines 406 408 +2
Branches 73 74 +1
==========================================
+ Hits 320 322 +2
Misses 69 69
Partials 17 17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
claravanstaden
approved these changes
Mar 4, 2024
vgeddes
reviewed
Mar 4, 2024
contracts/src/Assets.sol
Outdated
| @@ -23,6 +23,7 @@ library Assets { | |||
| error InvalidDestination(); | |||
| error TokenNotRegistered(); | |||
| error Unsupported(); | |||
| error InvalidDestFee(); | |||
There was a problem hiding this comment.
Suggested change
| error InvalidDestFee(); | |
| error InvalidDestinationFee(); |
vgeddes
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for https://bridgehub-rococo.stg.subscan.io/extrinsic/2583529-2
Requires: Snowfork/polkadot-sdk#119