Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle fee with error instead of silently ignoring #1107

Closed
wants to merge 8 commits into from

Conversation

yrong
Copy link
Contributor

@yrong yrong commented Jan 10, 2024

Resolves: SNO-820
Requires: Snowfork/polkadot-sdk#95

In edge cases like BridgeHubEthereumBaseFee insufficient or price params not correctly initialized, prefer to handle the fee with the error thrown instead of silently ignore.

Copy link

codecov bot commented Jan 10, 2024

Codecov Report

Attention: 31 lines in your changes are missing coverage. Please review.

Comparison is base (e0506f7) 76.36% compared to head (3894746) 76.03%.
Report is 2 commits behind head on main.

Files Patch % Lines
parachain/runtime/test-common/src/lib.rs 0.00% 24 Missing ⚠️
parachain/pallets/ethereum-client/src/impls.rs 0.00% 6 Missing ⚠️
parachain/runtime/runtime-common/src/lib.rs 94.44% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1107      +/-   ##
==========================================
- Coverage   76.36%   76.03%   -0.34%     
==========================================
  Files          56       58       +2     
  Lines        2344     2395      +51     
  Branches       72       72              
==========================================
+ Hits         1790     1821      +31     
- Misses        537      557      +20     
  Partials       17       17              
Flag Coverage Δ
rust 75.11% <36.73%> (-0.38%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yrong yrong requested a review from vgeddes January 10, 2024 15:49
@yrong
Copy link
Contributor Author

yrong commented Jan 11, 2024

Closes with #1109

@yrong yrong closed this Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant