Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport clippy fixes #1087

Merged
merged 2 commits into from
Jan 8, 2024
Merged

Backport clippy fixes #1087

merged 2 commits into from
Jan 8, 2024

Conversation

claravanstaden
Copy link
Contributor

@claravanstaden claravanstaden commented Dec 21, 2023

Apply fixes I made directly on paritytech/polkadot-sdk#2522 to please clippy. 📋

@claravanstaden claravanstaden marked this pull request as ready for review December 21, 2023 13:16
Copy link

codecov bot commented Dec 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (513fb46) 80.57% compared to head (eac5203) 80.57%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1087   +/-   ##
=======================================
  Coverage   80.57%   80.57%           
=======================================
  Files          55       55           
  Lines        2209     2209           
  Branches       72       72           
=======================================
  Hits         1780     1780           
  Misses        412      412           
  Partials       17       17           
Flag Coverage Δ
rust 80.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@vgeddes vgeddes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Contributor

@alistair-singh alistair-singh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@claravanstaden claravanstaden merged commit 902f8ab into main Jan 8, 2024
9 checks passed
@claravanstaden claravanstaden deleted the backport-clippy-fixes branch January 8, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants