Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport changes #1055

Merged
merged 9 commits into from
Dec 15, 2023
Merged

Backport changes #1055

merged 9 commits into from
Dec 15, 2023

Conversation

claravanstaden
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (738ae56) 81.27% compared to head (39fa0ac) 81.29%.
Report is 6 commits behind head on main.

Files Patch % Lines
parachain/pallets/system/src/benchmarking.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1055      +/-   ##
==========================================
+ Coverage   81.27%   81.29%   +0.01%     
==========================================
  Files          54       54              
  Lines        2238     2240       +2     
  Branches       71       71              
==========================================
+ Hits         1819     1821       +2     
  Misses        402      402              
  Partials       17       17              
Flag Coverage Δ
rust 81.45% <66.66%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@claravanstaden claravanstaden marked this pull request as ready for review December 15, 2023 10:27
@@ -0,0 +1,123 @@
#!/bin/bash
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still need to tweak this file but I'll make a separate PR, need to merge these changes asap.

Copy link
Collaborator

@vgeddes vgeddes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@claravanstaden claravanstaden merged commit 63906dd into main Dec 15, 2023
7 checks passed
@claravanstaden claravanstaden deleted the backport-changes branch December 15, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants