Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CustomDigestItem type #1053

Merged
merged 10 commits into from
Dec 16, 2023
Merged

Add CustomDigestItem type #1053

merged 10 commits into from
Dec 16, 2023

Conversation

vgeddes
Copy link
Collaborator

@vgeddes vgeddes commented Dec 14, 2023

The outbound queue pallet inserts a merkle root as a custom digest item into the parachain header.

To play nice with other bridges, this type allows these bridges to insert their own custom digest items, while making sure they don't conflict with each other.

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (09a9253) 81.30% compared to head (d0d2944) 81.31%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1053      +/-   ##
==========================================
+ Coverage   81.30%   81.31%   +0.01%     
==========================================
  Files          54       54              
  Lines        2241     2243       +2     
  Branches       71       71              
==========================================
+ Hits         1822     1824       +2     
  Misses        402      402              
  Partials       17       17              
Flag Coverage Δ
rust 81.46% <100.00%> (ø)
solidity 80.61% <100.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yrong
Copy link
Contributor

yrong commented Dec 15, 2023

Copy link
Contributor

@yrong yrong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All smoke tests work as expected, should be fine now.

Copy link
Contributor

@claravanstaden claravanstaden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@vgeddes vgeddes merged commit 4c175e4 into main Dec 16, 2023
8 checks passed
@vgeddes vgeddes deleted the custom-digest-item branch December 16, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants