You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
BEEFY justifications are encoded as VersionedFinalityProofs.
Snowbridge's commitment scanner currently parses these BEEFY justifications as OptionalSignedCommitmenthere.
This inadvertently works because the first byte of an encoded VersionedFinalityProof signals the version (currently strictly 1), which overlaps with the 1 used to signal Some(..) in an encoded option.
However, it will break once we add new VersionedFinalityProof versions, such as required for paritytech/polkadot-sdk#1119.
The text was updated successfully, but these errors were encountered:
BEEFY justifications are encoded as
VersionedFinalityProof
s.Snowbridge's commitment scanner currently parses these BEEFY justifications as
OptionalSignedCommitment
here.This inadvertently works because the first byte of an encoded
VersionedFinalityProof
signals the version (currently strictly1
), which overlaps with the1
used to signalSome(..)
in an encoded option.However, it will break once we add new
VersionedFinalityProof
versions, such as required for paritytech/polkadot-sdk#1119.The text was updated successfully, but these errors were encountered: