Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Api part 2 #98

Merged
merged 17 commits into from
Aug 13, 2024
Merged

Api part 2 #98

merged 17 commits into from
Aug 13, 2024

Conversation

micahjohnson150
Copy link
Member

  • Added in some support for rasters.
  • Added in some simplifying of the results from .all_*
  • Added in from_unique_entries which allows users to find options for a query theyre working on . Example: what dates did specific surface area get collected.
  • Addresses Support for geopandas>=1.0 #97

@jomey
Copy link
Member

jomey commented Aug 1, 2024

Just a quick reminder to keep track of the changes and maybe start a manual CHANGELOG.md for now until I get back to #85 and automate this?

Copy link
Contributor

@micah-prime micah-prime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just had one suggestion that is a result of what I added being out of sync

snowexsql/api.py Show resolved Hide resolved
snowexsql/api.py Outdated Show resolved Hide resolved
@micah-prime
Copy link
Contributor

@micahjohnson150 are we missing some commits? I don't see what you're referencing with 'Added in some support for rasters.'

@micahjohnson150
Copy link
Member Author

@micah-prime you were correct. I hadnt pushed everything apparently and got my edits and commits mixed up lol. This should be everything I have.

snowexsql/api.py Outdated Show resolved Hide resolved
snowexsql/api.py Outdated Show resolved Hide resolved
Copy link
Contributor

@micah-prime micah-prime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Couple of minor asks

@micah-prime
Copy link
Contributor

Just a quick reminder to keep track of the changes and maybe start a manual CHANGELOG.md for now until I get back to #85 and automate this?

I'm going to merge #85 for now so we can update that. Then I'll merge into this branch so we have a changelog to update

@micah-prime micah-prime self-requested a review August 13, 2024 15:51
@micah-prime micah-prime merged commit 978098a into master Aug 13, 2024
10 checks passed
@micah-prime micah-prime deleted the api_part_2 branch August 13, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants