Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change all string column types to text #148

Open
aaarendt opened this issue Oct 3, 2024 · 3 comments
Open

Change all string column types to text #148

aaarendt opened this issue Oct 3, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@aaarendt
Copy link
Contributor

aaarendt commented Oct 3, 2024

Suggest we replace all type declarations of "String" to "Text" following this postgres wiki.

@aaarendt aaarendt added the enhancement New feature or request label Oct 3, 2024
@micah-prime
Copy link
Contributor

Is there an advantage to using text instead of just String without the limit? The wiki seems agnostic on that

@aaarendt
Copy link
Contributor Author

aaarendt commented Oct 7, 2024

Good question. I think the answer within PostgreSQL is there's no difference. But according to the SQLAlchemy docs, you are required to specify a length if you use string within a CREATE TABLE statement. That is because some databases behave differently than others.

@micah-prime
Copy link
Contributor

Ah, makes sense! Text seems like a great choice then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants