-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTML content and bcc support #12
Comments
Hi Selwin, I'm more than happy to accept feature patches! In fact, if you (or anyone) can prove their code quality, I'm willing to have them as direct members of the project. There are some things which need to change with django-mailer-2. Issue #9 is the kicker - we need to be pickling the entire EmailMessage rather than the smtp text. If I recall from last time I looked, this is the stage where django-mailer [the original] has actually got to, so some code / ideas at least can be stolen from there. Sorry, just rambling there. Back on track, you shouldn't need to alter send_mail at all. Why can't you just use the |
Hi Chris, Regarding Issue #9, from a brief glance of the code I think this can be done relatively easily. We can change the I've used the original django-mailer for a few projects but didn't like the fact that it just stores the entire pickled email object without storing any information in a more structured manner so I couldn't sort/search the log/queue by recipient etc. How about we add a new |
Taking a closer look at the code, it seems like we don't have enough info to convert a
This will give us enough info to reconstruct an What do you think? |
Hi Chris, I took a first stab at converting the email sending to use EmailMessage.send() on my branch. Any thoughts? I haven't tested the code thoroughly but I did verify that it worked on non SMTP backends such as |
add ru translation + whitespace cleanup
Hi Chris,
I have a need for sending HTML emails with bcc and I was just wondering if you're open to accepting patches for either or both features.
My current plan is to make the send_mail command accept extra arguments (html_message and bcc).
For HTML content, this is relatively easy, I just need to tweak the send_mail command slightly to use EmailMultiAlternatives rather than the EmailMessage[1].
The bcc support would require an additional field to the Message model.
Regards,
Selwin
[1]https://docs.djangoproject.com/en/dev/topics/email/
The text was updated successfully, but these errors were encountered: