Add more protection options for RedProtectProtectionModule #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheBusyBiscuit
requested changes
Dec 24, 2021
| @@ -46,7 +49,15 @@ public boolean hasPermission(OfflinePlayer p, Location l, Interaction action) { | |||
| Player player = (Player) p; | |||
| switch (action) { | |||
| case INTERACT_BLOCK: | |||
| return region.canChest(player); | |||
| if (l.getBlock() instanceof Container){ | |||
There was a problem hiding this comment.
Container is an extension of BlockState, only the block's state can therefore be an instance of Container.
Comment on lines
+55
to
+60
| if (l.getBlock().getBlockData() instanceof Powerable){ | ||
| return region.canButton(player) || region.canLever(player); | ||
| } | ||
| if (l.getBlock().getBlockData() instanceof Openable){ | ||
| return region.canDoor(player); | ||
| } |
There was a problem hiding this comment.
Block#getBlockData() is a rather expensive check, Block#getState() is even worse.
A material check would yield significantly better performance here
Also, you are potentially calling Block#getBlockData() twice per run here too which is redundant.
|
Marking this as stale |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add more protection options for RedProtectProtectionModule