-
Notifications
You must be signed in to change notification settings - Fork 546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/flint and steal unbreaking #4247
Open
Intybyte
wants to merge
8
commits into
Slimefun:master
Choose a base branch
from
Intybyte:feature/flint-and-steal-unbreaking
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feature/flint and steal unbreaking #4247
Intybyte
wants to merge
8
commits into
Slimefun:master
from
Intybyte:feature/flint-and-steal-unbreaking
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your Pull Request was automatically labelled as: "🎈 Feature" |
Slimefun preview buildA Slimefun preview build is available for testing! https://preview-builds.walshy.dev/download/Slimefun/4247/5a823160
|
JustAHuman-xD
requested changes
Oct 26, 2024
...ain/java/io/github/thebusybiscuit/slimefun4/implementation/items/blocks/IgnitionChamber.java
Outdated
Show resolved
Hide resolved
...ain/java/io/github/thebusybiscuit/slimefun4/implementation/items/blocks/IgnitionChamber.java
Outdated
Show resolved
Hide resolved
…n/items/blocks/IgnitionChamber.java Co-authored-by: JustAHuman-xD <[email protected]>
… add break sound to flint and steel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make the Automatic Ignition chamber respect the level of the Unbreaking enchantment on the tool selected for durability loss (thus, an Unbreaking 3 Flint and Steel would last 4 times as long on average).
Proposed changes
Refactor the code releated to damaging the flint and steal into a
damageFlintAndSteel
method that uses vanilla MC unbreaking calculation to determine when to damage the flint and stealRelated Issues (if applicable)
Suggestion 2429 #approved
Checklist
Nonnull
andNullable
annotations to my methods to indicate their behaviour for null values